Add sequenceId slot and fix effect promises #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gterzian, do you want to check this also? |
|
Will need to check if the original issue is observable in any browser or if there was code already preventing this. Might be good if we can come up with a test to confirm (seems it might be possible to do so). |
|
@nondebug I'm still not sure what happens if the identifiers don't match... feels like there should be some kind of assert or something somewhere to assuring nothing is getting out of sync. |
There was a problem hiding this comment.
Adding @gterzian's suggestions would be great. Can review again after those updates.
|
@gterzian Thanks for the suggestions! @marcoscaceres Please take another look |
marcoscaceres
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200
The following tasks have been completed:
Implementation commitment:
Preview | Diff